William Wei has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
mb/google/volteer/malefor: Update overridetree.cb
1) Based on malefor schematics, disable unused I2C port, USB port, TBT PCIe 2) Add audio device to the tree, should update fw_config at the same time
BUG=b:150653745 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the devices' function worked properly.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb --- M src/mainboard/google/volteer/variants/malefor/overridetree.cb 1 file changed, 81 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/42246/1
diff --git a/src/mainboard/google/volteer/variants/malefor/overridetree.cb b/src/mainboard/google/volteer/variants/malefor/overridetree.cb index 8d4c6ea..5e0f320 100644 --- a/src/mainboard/google/volteer/variants/malefor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/malefor/overridetree.cb @@ -1,6 +1,76 @@ chip soc/intel/tigerlake
+ # USB Port Config + register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 + register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[2]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C C1 + register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # M.2 Camera + register "usb2_ports[5]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[7]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C C0 + register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # M.2 Bluetooth + + register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC1)" # USB3/2 Type A port A0 + register "usb3_ports[1]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used + + # I2C Port Config + register "SerialIoI2cMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoDisabled, + [PchSerialIoIndexI2C4] = PchSerialIoDisabled, + [PchSerialIoIndexI2C5] = PchSerialIoPci, + }" + device domain 0 on + device pci 07.0 off end # TBT_PCIe0 0x9A23 + device pci 07.1 off end # TBT_PCIe1 0x9A25 + device pci 07.2 off end # TBT_PCIe2 0x9A27 + device pci 07.3 off end # TBT_PCIe3 0x9A29 + + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Headset Codec"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" + # Set the jd_src to RT5668_JD1 for jack detection + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on + probe AUDIO MAX98357_ALC5682I_I2S + probe AUDIO MAX98373_ALC5682I_I2S + end + end + chip drivers/i2c/max98373 + register "vmon_slot_no" = "0" + register "imon_slot_no" = "1" + register "uid" = "0" + register "desc" = ""Right Speaker Amp"" + register "name" = ""MAXR"" + device i2c 31 on + probe AUDIO MAX98373_ALC5682I_I2S + end + end + chip drivers/i2c/max98373 + register "vmon_slot_no" = "2" + register "imon_slot_no" = "3" + register "uid" = "1" + register "desc" = ""Left Speaker Amp"" + register "name" = ""MAXL"" + device i2c 32 on + probe AUDIO MAX98373_ALC5682I_I2S + end + end + end + device pci 15.1 on chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" @@ -19,6 +89,17 @@ device i2c 5d on end end end # I2C1 + + device pci 1f.3 on + chip drivers/generic/max98357a + register "hid" = ""MX98357A"" + register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" + register "sdmode_delay" = "5" + device generic 0 on + probe AUDIO MAX98357_ALC5682I_I2S + end + end + end end
end
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 1: Code-Review+1
Please kindly help to review this CL, many thanks!
William Wei has removed Alex Levin from this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Removed reviewer Alex Levin.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 1: Code-Review+1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 1:
(1 comment)
i see you're adding support for multiple audio DBs. is that just copy-paste from volteer or is that intended for malefor?
https://review.coreboot.org/c/coreboot/+/42246/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/1/src/mainboard/google/voltee... PS1, Line 99: MAX98357_ALC5682I_I2S is the max98360 software compatible with the max98357? there's no i2c interface, so there's just no additional software support needed?
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
i see you're adding support for multiple audio DBs. is that just copy-paste from volteer or is that intended for malefor?
You're right, I copied volteer audio solution and removed "drivers/intel/soundwire". Malefor doesn't use max98373, I'll submit a new patchset to remove all the max98373 driver.
https://review.coreboot.org/c/coreboot/+/42246/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/1/src/mainboard/google/voltee... PS1, Line 99: MAX98357_ALC5682I_I2S
is the max98360 software compatible with the max98357? there's no i2c interface, […]
Yes, max98360 and max98357 share the same driver, details please refer to below CR（https://partnerissuetracker.corp.google.com/issues/144298581%EF%BC%89
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Caveh Jalali, Alex Levin, Paul Menzel, Zhuohao Lee, Aaron Durbin, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42246
to look at the new patch set (#2).
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
mb/google/volteer/malefor: Update overridetree.cb
1) Based on malefor schematics, disable unused I2C port, USB port, TBT PCIe 2) Add audio device to the tree, should update fw_config at the same time
BUG=b:150653745 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the devices' function worked properly.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb --- M src/mainboard/google/volteer/variants/malefor/overridetree.cb 1 file changed, 60 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/42246/2
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 2: Code-Review+1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
i see you're adding support for multiple audio DBs. is that just copy-paste from volteer or is that intended for malefor?
You're right, I copied volteer audio solution and removed "drivers/intel/soundwire". Malefor doesn't use max98373, I'll submit a new patchset to remove all the max98373 driver.
the next question is whether you even need the "probe" statement. if you plan to support exactly one audio board, you don't really need to probe. all the probe is going to do is to consult the fw_config bits to see if you have a matching audio DB type specified. this is pretty much redundant unless you want to be able to specify "none" for the audio DB as an option - this might be useful for testing.
anyway, think about whether malefor needs to use the audio DB type field in fw_config at all.
https://review.coreboot.org/c/coreboot/+/42246/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/2/src/mainboard/google/voltee... PS2, Line 50: extra blank line?
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Caveh Jalali, Alex Levin, Paul Menzel, Zhuohao Lee, Aaron Durbin, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42246
to look at the new patch set (#3).
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
mb/google/volteer/malefor: Update overridetree.cb
1) Based on malefor schematics, disable unused I2C port, USB port, TBT PCIe 2) Add audio device to the tree, should update fw_config at the same time
BUG=b:150653745 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the devices' function worked properly.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb --- M src/mainboard/google/volteer/variants/malefor/overridetree.cb 1 file changed, 53 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/42246/3
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 3:
(1 comment)
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
i see you're adding support for multiple audio DBs. is that just copy-paste from volteer or is that intended for malefor?
You're right, I copied volteer audio solution and removed "drivers/intel/soundwire". Malefor doesn't use max98373, I'll submit a new patchset to remove all the max98373 driver.
the next question is whether you even need the "probe" statement. if you plan to support exactly one audio board, you don't really need to probe. all the probe is going to do is to consult the fw_config bits to see if you have a matching audio DB type specified. this is pretty much redundant unless you want to be able to specify "none" for the audio DB as an option - this might be useful for testing.
anyway, think about whether malefor needs to use the audio DB type field in fw_config at all.
Many thanks for your suggestion, we don't have the plan to test "none audio DB" at present. Remove the "probe" statement.
https://review.coreboot.org/c/coreboot/+/42246/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/2/src/mainboard/google/voltee... PS2, Line 50:
extra blank line?
Done
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 3: Code-Review+1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42246/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42246/3//COMMIT_MSG@11 PS3, Line 11: update fw_config you don't need fw_config for audio DB selection any more since you'll only have 1 config.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Caveh Jalali, Alex Levin, Paul Menzel, Zhuohao Lee, Aaron Durbin, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42246
to look at the new patch set (#4).
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
mb/google/volteer/malefor: Update overridetree.cb
1) Based on malefor schematics, disable unused I2C port, USB port, TBT PCIe 2) Add audio device to the tree
BUG=b:150653745, b:154973095 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the devices' function worked properly.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb --- M src/mainboard/google/volteer/variants/malefor/overridetree.cb 1 file changed, 53 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/42246/4
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42246/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42246/3//COMMIT_MSG@11 PS3, Line 11: update fw_config
you don't need fw_config for audio DB selection any more since […]
Thanks for your reminding, done
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 4: Code-Review+1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 4: Code-Review+1
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 4:
ping...
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee... PS4, Line 16: USB3_PORT_EMPTY Just curious: No USB3 ports for C1 and C0?
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee... PS4, Line 22: nit: use tabs instead of spaces here and in the lines below.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Caveh Jalali, Alex Levin, Paul Menzel, Nick Vaccaro, Zhuohao Lee, Aaron Durbin, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42246
to look at the new patch set (#5).
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
mb/google/volteer/malefor: Update overridetree.cb
1) Based on malefor schematics, disable unused I2C port, USB port, TBT PCIe 2) Add audio device to the tree
BUG=b:150653745, b:154973095 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the devices' function worked properly.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb --- M src/mainboard/google/volteer/variants/malefor/overridetree.cb 1 file changed, 53 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/42246/5
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee... PS4, Line 16: USB3_PORT_EMPTY
Just curious: No USB3 ports for C1 and C0?
C0 and C1 port attached the processor XHCI USB3, device tree here only define the PCH XHCI USB3. So it seems a little strange.
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee... PS4, Line 22:
nit: use tabs instead of spaces here and in the lines below.
Done, many thanks
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Caveh Jalali, Alex Levin, Paul Menzel, Nick Vaccaro, Zhuohao Lee, Aaron Durbin, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42246
to look at the new patch set (#6).
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
mb/google/volteer/malefor: Update overridetree.cb
1) Based on malefor schematics, disable unused I2C port, USB port, TBT PCIe 2) Add audio device to the tree
BUG=b:150653745, b:154973095 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the devices' function worked properly.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb --- M src/mainboard/google/volteer/variants/malefor/overridetree.cb 1 file changed, 53 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/42246/6
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 6: Code-Review+1
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42246/4/src/mainboard/google/voltee... PS4, Line 16: USB3_PORT_EMPTY
C0 and C1 port attached the processor XHCI USB3, device tree here only define the PCH XHCI USB3. […]
Done
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42246/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42246/6//COMMIT_MSG@12 PS6, Line 12: also mention SAR and touchscreen.
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42246/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42246/6//COMMIT_MSG@12 PS6, Line 12:
also mention SAR and touchscreen.
SAR and touchscreen were added by Nick's CL, I've done a re-base to deal with the merge conflict. Should I add these on commit message?
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42246/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42246/6//COMMIT_MSG@12 PS6, Line 12:
SAR and touchscreen were added by Nick's CL, I've done a re-base to deal with the merge conflict. […]
oh, sorry my mistake. gerrit should have highlighted that section in blue or something when i looked at the patchset diffs.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42246 )
Change subject: mb/google/volteer/malefor: Update overridetree.cb ......................................................................
mb/google/volteer/malefor: Update overridetree.cb
1) Based on malefor schematics, disable unused I2C port, USB port, TBT PCIe 2) Add audio device to the tree
BUG=b:150653745, b:154973095 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the devices' function worked properly.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I9ce465705e8b8f67ddbc9e4eb06c5a8bfac65fcb Reviewed-on: https://review.coreboot.org/c/coreboot/+/42246 Reviewed-by: Caveh Jalali caveh@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/malefor/overridetree.cb 1 file changed, 53 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved William Wei: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/malefor/overridetree.cb b/src/mainboard/google/volteer/variants/malefor/overridetree.cb index 84493f8..b2a658c 100644 --- a/src/mainboard/google/volteer/variants/malefor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/malefor/overridetree.cb @@ -1,6 +1,51 @@ chip soc/intel/tigerlake
+ # USB Port Config + register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 + register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[2]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C C1 + register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # M.2 Camera + register "usb2_ports[5]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[7]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C C0 + register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # M.2 Bluetooth + + register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC1)" # USB3/2 Type A port A0 + register "usb3_ports[1]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Type-A / Type-C Not Used + + # I2C Port Config + register "SerialIoI2cMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoDisabled, + [PchSerialIoIndexI2C4] = PchSerialIoDisabled, + [PchSerialIoIndexI2C5] = PchSerialIoPci, + }" + device domain 0 on + device pci 07.0 off end # TBT_PCIe0 0x9A23 + device pci 07.1 off end # TBT_PCIe1 0x9A25 + device pci 07.2 off end # TBT_PCIe2 0x9A27 + device pci 07.3 off end # TBT_PCIe3 0x9A29 + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Headset Codec"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)" + # Set the jd_src to RT5668_JD1 for jack detection + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + end # I2C0 device pci 15.1 on chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" @@ -61,5 +106,13 @@ device i2c 15 on end end end # I2C5 0xA0C6 + device pci 1f.3 on + chip drivers/generic/max98357a + register "hid" = ""MX98357A"" + register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" + register "sdmode_delay" = "5" + device generic 0 on end + end + end # Intel HD audio end end
-
Caveh Jalali (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
William Wei (Code Review)
-
Zhuohao Lee (Code Review)