Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Eric Lai, Elyes Haouas.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68593 )
Change subject: acpi/Kconfig: Remove unused ACPI_EINJ config option
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
This is not about the code feature but the dead Kconfig. If there is code
around the Kconfig downstream, the Kconfig should stay with the downstream
code.
Nobody has suggested to remove the code. However, I would be careful with
linked binaries. The GPL might force you to publish your sensitive code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99
Gerrit-Change-Number: 68593
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 16 Nov 2022 09:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment