[XS] Change in coreboot[main]: soc/intel/alderlake/romstage: Update PchHdaSdiEnable for AlderLakeN - coreboot-gerrit

11 Jul 2024


      Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83428?usp=email )
Change subject: soc/intel/alderlake/romstage: Update PchHdaSdiEnable for AlderLakeN
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83428/comment/e9938999_103028ca?usp... :
PS1, Line 254: #if CONFIG(SOC_INTEL_ALDERLAKE_PCH_N)
u r basically limiting !ADL-N to override PchHdaSdiEnable UPDs. Why so?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83428?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia413588e75fbbc11440d1cdf81532ef89f4dcf1e
Gerrit-Change-Number: 83428
Gerrit-PatchSet: 1
Gerrit-Owner: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 11 Jul 2024 14:58:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No