Change in ...coreboot[master]: drivers/pc80/rtc/mc146818rtc.c: Reset RTC time on RTC power failure - coreboot-gerrit

5 Apr 2019


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29329 )
Change subject: drivers/pc80/rtc/mc146818rtc.c: Reset RTC time on RTC power failure
......................................................................
Patch Set 7: Code-Review+2
Thanks for the ping. I don't have time to look further
into this, the code seems unnecessarily complex and
could use some refactoring. But this change is correct
anyway (given how the callers interpret `invalid`).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29329
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eae57d00f328400a8b03c28b7ecdbbc71522206
Gerrit-Change-Number: 29329
Gerrit-PatchSet: 7
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 05 Apr 2019 12:37:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment