Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85206?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/fatcat/var/francka: Use RAM ID 1 for MT62F2G32D4DS-020 WT:F ......................................................................
mb/google/fatcat/var/francka: Use RAM ID 1 for MT62F2G32D4DS-020 WT:F
Change the ram_id to 1 for MT62F2G32D4DS-020 WT:F based on the hardware schematic MB_SCH_1102A.
BUG=b:372395010 TEST=Run part_id_gen tool and check the generated files.
Change-Id: I8cf0e65036c2da7641f29b2975dece718f7c83e3 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85206 Reviewed-by: Pranava Y N pranavayn@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk M src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt M src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt 3 files changed, 6 insertions(+), 5 deletions(-)
Approvals: Dtrain Hsu: Looks good to me, approved build bot (Jenkins): Verified Pranava Y N: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk b/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk index 62c45356..310ef55 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk +++ b/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk @@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# util/spd_tools/bin/part_id_gen ptl lp5 src/mainboard/google/fatcat/variants/francka/memory/ src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt +# util/spd_tools/bin/part_id_gen PTL lp5 src/mainboard/google/fatcat/variants/francka/memory src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt
SPD_SOURCES = -SPD_SOURCES += spd/lp5/set-0/spd-10.hex # ID = 0(0b0000) Parts = MT62F2G32D4DS-020 WT:F +SPD_SOURCES += spd/lp5/set-0/spd-empty.hex # ID = 0(0b0000) +SPD_SOURCES += spd/lp5/set-0/spd-10.hex # ID = 1(0b0001) Parts = MT62F2G32D4DS-020 WT:F diff --git a/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt b/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt index 31165c4..dcb790a 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt +++ b/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# util/spd_tools/bin/part_id_gen ptl lp5 src/mainboard/google/fatcat/variants/francka/memory/ src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt +# util/spd_tools/bin/part_id_gen PTL lp5 src/mainboard/google/fatcat/variants/francka/memory src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt
DRAM Part Name ID to assign -MT62F2G32D4DS-020 WT:F 0 (0000) +MT62F2G32D4DS-020 WT:F 1 (0001) diff --git a/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt b/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt index e6822f6..9b80035 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt +++ b/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt @@ -9,4 +9,4 @@ # See util/spd_tools/README.md for more details and instructions.
# Part Name -MT62F2G32D4DS-020 WT:F +MT62F2G32D4DS-020 WT:F,1