Attention is currently required from: Felix Singer, Jonathon Hall, Michael Niewöhner.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75090 )
Change subject: mb/purism/librem_l1um_v2: Add support for Purism Librem L1UM v2
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/purism/librem_l1um_v2/bootblock.c:
https://review.coreboot.org/c/coreboot/+/75090/comment/e7a5b293_8ad2664e
PS1, Line 17: int64_t bmc_ready_elapsed = 0;
nit: should be `static`
File src/mainboard/purism/librem_l1um_v2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75090/comment/4ae8700f_a70ff7cc
PS1, Line 273: register "bmc_boot_timeout" = "90"
just a note that this is inconsistent with the bootblock waiting 120 seconds, any reason for that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I990f6024d65098a9553d7d1fe7f36614cc55ea19
Gerrit-Change-Number: 75090
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 10 May 2023 16:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment