Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Angel Pons, Michael Niewöhner.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58271 )
Change subject: arch/x86/smbios: Add generation of type 20 table
......................................................................
Patch Set 4:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/58271/comment/6aed41c9_d8b6eb99
PS4, Line 1073: (end_addr + 1)
nit: braces not needed
Ack
https://review.coreboot.org/c/coreboot/+/58271/comment/7e899bee_2a3e5dc2
PS4, Line 1073: +=
Is the `+=` correct? I'd use `=` instead.
there's one type20 table per dimm; start_addr starts at 0 and increments by the size of the dimm for each loop iteration
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58271
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2574d6209d973a8e7f112eb3ef61f5d26986e47b
Gerrit-Change-Number: 58271
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 12 Oct 2021 15:44:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment