Attention is currently required from: Paul Menzel, Meera Ravindranath, Casper Chang.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60417 )
Change subject: mb/google/brya/var/primus4es: reconfig USE_PM_ACPI_TIMER
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60417/comment/0f3ed727_f390c13b
PS2, Line 9: Config USE_PM_ACPI_TIMER to y for primus4es only as
: commit 1ce0f3aab7 (mb/google/brya: Fix S0i3 regression)
: breaks suspend stress test on ES CPU SKU.
ping
Why?
Patchset:
PS2:
Could we submit this CL to enable S0iX on ES CPU?
Out of curiosity was it ever tested if this enables S0ix? e.g. by power
measurements? I still assume it's the opposite, S0ix gets disabled a
little more so it won't crash.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60417
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d19c10e2029e233542a8ceec272f8ede2b4bfac
Gerrit-Change-Number: 60417
Gerrit-PatchSet: 2
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Feb 2022 16:57:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-MessageType: comment