Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84774?usp=email )
Change subject: soc/mediatek/common: Add read16/write16 support for PMIF
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/soc/mediatek/common/pmif.c:
https://review.coreboot.org/c/coreboot/+/84774/comment/7b8e0ddf_d285b505?usp... :
PS3, Line 67: pmif_spmi_read
The current implementation of `clk_buf_init()` in `src/soc/mediatek/common/clkbuf. […]
Fine. Let's also file a bug for that so that we won't forget the issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84774?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3adbbaaf247a8bbd99627cf089b5b55fcf4fb115
Gerrit-Change-Number: 84774
Gerrit-PatchSet: 7
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 02 Dec 2024 04:06:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com