Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48214 )
Change subject: cpu/x86/smm/smm_stub: Fix GDT for x86_64 ......................................................................
cpu/x86/smm/smm_stub: Fix GDT for x86_64
The previous code was crashing when jumping back to ramstage, now it works. The GDT is now using the same values as the other ones in coreboot.
Change-Id: Id00467d9d8a4138ddea73adbda4b39f12def583f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/x86/smm/smm_stub.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/48214/1
diff --git a/src/cpu/x86/smm/smm_stub.S b/src/cpu/x86/smm/smm_stub.S index 11ea9a7..56e2504 100644 --- a/src/cpu/x86/smm/smm_stub.S +++ b/src/cpu/x86/smm/smm_stub.S @@ -91,7 +91,7 @@
/* gdt selector 0x18, flat code segment (64-bit) */ .word 0xffff, 0x0000 - .byte 0x00, 0x9b, 0xcf, 0x00 + .byte 0x00, 0x9b, 0xaf, 0x00
/* gdt selector 0x20 tss segment */ .word 0xffff, 0x0000
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48214 )
Change subject: cpu/x86/smm/smm_stub: Fix GDT for x86_64 ......................................................................
Patch Set 1: Code-Review+2
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48214 )
Change subject: cpu/x86/smm/smm_stub: Fix GDT for x86_64 ......................................................................
cpu/x86/smm/smm_stub: Fix GDT for x86_64
The previous code was crashing when jumping back to ramstage, now it works. The GDT is now using the same values as the other ones in coreboot.
Change-Id: Id00467d9d8a4138ddea73adbda4b39f12def583f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48214 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/x86/smm/smm_stub.S 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/cpu/x86/smm/smm_stub.S b/src/cpu/x86/smm/smm_stub.S index 11ea9a7..56e2504 100644 --- a/src/cpu/x86/smm/smm_stub.S +++ b/src/cpu/x86/smm/smm_stub.S @@ -91,7 +91,7 @@
/* gdt selector 0x18, flat code segment (64-bit) */ .word 0xffff, 0x0000 - .byte 0x00, 0x9b, 0xcf, 0x00 + .byte 0x00, 0x9b, 0xaf, 0x00
/* gdt selector 0x20 tss segment */ .word 0xffff, 0x0000
-
Arthur Heymans (Code Review) -
Patrick Rudolph (Code Review)