Attention is currently required from: Johnny Lin, Paul Menzel, Christian Walter, Jingle Hsu, Arthur Heymans, Morgan Jang, Tim Chu, Shelly_Chang@wiwynn.com.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58100 )
Change subject: mb/ocp/deltalake: Fix SMBIOS type 9 bugs
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58100/comment/d6bd980f_d9dc1bcc
PS5, Line 9: was not really read
not being really read
I'd say `wasn't being read` is more accurate.
https://review.coreboot.org/c/coreboot/+/58100/comment/e519cbb1_659173e1
PS5, Line 13: 2. Initiailize the characteristics flags to 0 in the for-loop.
To fix what?
The variables for the characteristics flags are only modified using `|=`, but the original code never reset their value after each iteration. As a result, the values from previous iterations would persist.
https://review.coreboot.org/c/coreboot/+/58100/comment/a0f92515_bb1071e5
PS5, Line 13: Initiailize
one `i` too many: Initia*lize
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9
Gerrit-Change-Number: 58100
Gerrit-PatchSet: 5
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Wed, 06 Oct 2021 09:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment