Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60386 )
Change subject: mb/google/corsola: Fully calibrate DRAM
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60386/comment/fe77e6d1_856991c2
PS3, Line 9: Initialize and calibrate DRAM in romstage.
what do you mean?
Without full calibration (basic(?)), did the board boot?
Commit Message:
https://review.coreboot.org/c/coreboot/+/60386/comment/3e71792d_ec512eb0
PS4, Line 13: 20014 msecs
That’s 20 seconds, wow!
Maybe also post a log with already warm MRC cache.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80a18a8be5b1d47a5f0f7afed9601c0884e69035
Gerrit-Change-Number: 60386
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ryan Chuang
ryan.chuang@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Comment-Date: Mon, 27 Dec 2021 13:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment