Attention is currently required from: Martin L Roth, Martin Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68195 )
Change subject: soc/amd/morgana: Add initial commit for new SoC
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68195/comment/63dcda92_7f1a207b
PS2, Line 12: commonization.
Did you add TODOs for every file or did you check already which files
might need to be changed?
To keep track of the compatibility of common code, it would be nice to
also add TODOs for the respective Kconfig selects, like it was done in
CB:61077.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If92e129db10d41595e1dc18a7c1dfe99d57790cc
Gerrit-Change-Number: 68195
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 10 Oct 2022 09:44:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment