Attention is currently required from: Martin Roth, Idwer Vollering, Paul Menzel, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56803 )
Change subject: util/genbuild_h: micro-adjust the regexp used to set COREBOOT_MAJOR_VERSION
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56803/comment/26743925_41801d09
PS3, Line 12:
Please break long lines; line-length limit for commit messages is 72 chars.
Patchset:
PS3:
Commit message should get an update, looks fine otherwise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c0c260fd8d42e23a612a353a288e472cc068c8e
Gerrit-Change-Number: 56803
Gerrit-PatchSet: 3
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 22 Aug 2021 21:38:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment