Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Paul Menzel, Sridhar Siricilla.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: drivers/intel/ish: Hook get ISH version into `.final`
......................................................................
Patch Set 17:
(1 comment)
File src/drivers/intel/ish/ish.c:
https://review.coreboot.org/c/coreboot/+/74209/comment/bf017294_0f337148
PS17, Line 53: struct cse_fw_partition_info *version = cbmem_find(CBMEM_ID_CSE_PARTITION_VERSION);
: if (version == NULL)
: return;
:
: printk(BIOS_DEBUG, "ISH version: %d.%d.%d.%d\n",
: version->ish_partition_info.cur_ish_fw_version.major,
: version->ish_partition_info.cur_ish_fw_version.minor,
: version->ish_partition_info.cur_ish_fw_version.hotfix,
: version->ish_partition_info.cur_ish_fw_version.build);
I'm confused. Is finding the ish_partition_info ever not done in ramstage? Why do you need to save in cbmem and not in a local data structure (static global variable) with functions to report it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8
Gerrit-Change-Number: 74209
Gerrit-PatchSet: 17
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Sat, 15 Apr 2023 09:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment