Attention is currently required from: Arthur Heymans, Christian Walter, Jérémy Compostella, Michał Kopeć, Michał Żygowski, Patrick Rudolph, Shuo Liu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81276?usp=email )
Change subject: drivers/pc80/tpm: Support Xeon-SP
......................................................................
Patch Set 7:
(3 comments)
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/81276/comment/28611b1d_2b75e6c9 :
PS7, Line 808: /* Windows 11 requires the following path for TPM to be detected */
Do we know that for sure? i.e. do we know that Windows 11 would accept a TPM
below a segment group that isn't called `PCI0'? Otherwise we should probably
change the comment to reflect what Arthur said.
https://review.coreboot.org/c/coreboot/+/81276/comment/deb81fd3_46e5882f :
PS7, Line 812: path = "\_SB_.PCI0";
While I could imagine a devicetree where the TPM device isn't below a domain
device, this path would certainly not work in that case.
I guess we should try the original code that was used before the Windows 11
quirk was added.
https://review.coreboot.org/c/coreboot/+/81276/comment/f8754c10_fd10500d :
PS7, Line 813:
`path` could be `NULL` here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81276?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6130b937ec81bbde78d2619eb859ecf354fc3854
Gerrit-Change-Number: 81276
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 16 Apr 2024 08:42:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment