Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66945 )
Change subject: soc/amd/mendocino: Add GSVCD range
......................................................................
Patch Set 12:
(1 comment)
File src/soc/amd/mendocino/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66945/comment/212d7580_806f0669
PS12, Line 332: Bootblock
Hrmm, does verstage not verify bootblock?
Actually not since amdfw.rom (in RO/Coreboot) contains metadata hash anchor and hence is excluded from CBFS verification. Also bootblock is not signed against AMD chain of trust and hence is not verified by PSP. So it makes sense to verify the bootblock by GSC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8a766d9a7ef26f94e3ab002a9384ba9d444dd1f
Gerrit-Change-Number: 66945
Gerrit-PatchSet: 12
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Oct 2022 17:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment