Change in coreboot[master]: mb/ocp/deltalake: add LPC device entry in ACPI

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jonathan Zhang (Code Review)

22 Sep 2020 22 Sep '20

10:24 a.m.

Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45592 )

Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................

mb/ocp/deltalake: add LPC device entry in ACPI

PCH LPC device is on CSTACK. Add LPC ACPI device entry.

Without this change, following error message shows up in target OS boot log: ACPI BIOS Error (bug): Failure looking up [_SB.PCI0.LPCB], AE_NOT_FOUND (20180105/dswload-211) ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20180105/psobject-252) ACPI Error: AE_NOT_FOUND, (SSDT:COREBOOT) while loading table (20180105/tbxfload-228) ACPI Error: 1 table load failures, 1 successful (20180105/tbxfload-246)

Also TPM device is not created.

TESTED=Booted DeltaLake DVT, run following command in target OS: [root@dhcp-100-96-192-153 ~]# dmesg | grep tpm [ 7.331890] tpm_tis MSFT0101:00: 2.0 TPM (device-id 0x1B, rev-id 16)

Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 --- M src/mainboard/ocp/deltalake/dsdt.asl 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/45592/1

diff --git a/src/mainboard/ocp/deltalake/dsdt.asl b/src/mainboard/ocp/deltalake/dsdt.asl index c74b5fe..4d784f3 100644 --- a/src/mainboard/ocp/deltalake/dsdt.asl +++ b/src/mainboard/ocp/deltalake/dsdt.asl @@ -20,4 +20,10 @@

// CPX-SP ACPI tables #include <soc/intel/xeon_sp/cpx/acpi/uncore.asl> + + // LPC related entries + Scope (_SB.PC00) + { + #include <soc/intel/common/block/acpi/acpi/lpc.asl> + } }

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Marc Jones (Code Review)

23 Sep 23 Sep

3:51 a.m.

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45592 )

Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45592/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/45592/1/src/mainboard/ocp/deltalake... PS1, Line 28: } There are probably several other PCH devices that will need asl code. It would be good to have this in southbridge.asl or pch.asl to be included here. This would fix all xeon_sp mainboards.

Same with the cpu and uncore.asl.

Jonathan Zhang (Code Review)

9:45 a.m.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45592 )

Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45592/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/45592/1/src/mainboard/ocp/deltalake... PS1, Line 28: }

...

There are probably several other PCH devices that will need asl code. […]

Makes sense. What about us doing that in another patch, when we add asl code for other PCH devices? For now,LPC device is needed to enable TPM feature.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 Gerrit-Change-Number: 45592 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marc Jones marc@marcjonesconsulting.com Gerrit-Comment-Date: Tue, 22 Sep 2020 23:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marc Jones marc@marcjonesconsulting.com Gerrit-MessageType: comment

Philipp Deppenwiese (Code Review)

10:45 a.m.

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45592 )

Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 Gerrit-Change-Number: 45592 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marc Jones marc@marcjonesconsulting.com Gerrit-Comment-Date: Wed, 23 Sep 2020 00:45:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

24 Sep 24 Sep

9:42 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45592 )

Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45592/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/45592/1/src/mainboard/ocp/deltalake... PS1, Line 28: }

...

Makes sense. […]

For now, I think this is good enough. If this starts growing, we can put it in a pch.asl file in soc code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 Gerrit-Change-Number: 45592 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marc Jones marc@marcjonesconsulting.com Gerrit-Comment-Date: Thu, 24 Sep 2020 11:42:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Marc Jones marc@marcjonesconsulting.com Comment-In-Reply-To: Jonathan Zhang jonzhang@fb.com Gerrit-MessageType: comment

Jonathan Zhang (Code Review)

25 Sep 25 Sep

5:26 a.m.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45592 )

Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45592/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/45592/1/src/mainboard/ocp/deltalake... PS1, Line 28: }

...

For now, I think this is good enough. If this starts growing, we can put it in a pch. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/45592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 Gerrit-Change-Number: 45592 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Marc Jones marc@marcjonesconsulting.com Gerrit-Comment-Date: Thu, 24 Sep 2020 19:26:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marc Jones marc@marcjonesconsulting.com Comment-In-Reply-To: Jonathan Zhang jonzhang@fb.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Marc Jones (Code Review)

26 Sep 26 Sep

2:22 a.m.

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45592 )

Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................

Patch Set 5: Code-Review+2

We will add pch.asl in follow-on patches. This can be committed if it is decoupled from CB:45590 for the builder to pass.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 Gerrit-Change-Number: 45592 Gerrit-PatchSet: 5 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 25 Sep 2020 16:22:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

28 Sep 28 Sep

7:39 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45592 )

Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................

mb/ocp/deltalake: add LPC device entry in ACPI

PCH LPC device is on CSTACK. Add LPC ACPI device entry.

Also TPM device is not created.

TESTED=Booted DeltaLake DVT, run following command in target OS: [root@dhcp-100-96-192-153 ~]# dmesg | grep tpm [ 7.331890] tpm_tis MSFT0101:00: 2.0 TPM (device-id 0x1B, rev-id 16)

Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45592 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marc Jones marc@marcjonesconsulting.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M src/mainboard/ocp/deltalake/dsdt.asl 1 file changed, 6 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Marc Jones: Looks good to me, approved Philipp Deppenwiese: Looks good to me, approved Angel Pons: Looks good to me, approved

// CPX-SP ACPI tables #include <soc/intel/xeon_sp/cpx/acpi/uncore.asl> + + // LPC related entries + Scope (_SB.PC00) + { + #include <soc/intel/common/block/acpi/acpi/lpc.asl> + } }

-- To view, visit https://review.coreboot.org/c/coreboot/+/45592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 Gerrit-Change-Number: 45592 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathan Zhang jonzhang@fb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1471

days inactive

1477

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Jonathan Zhang (Code Review)
Marc Jones (Code Review)
Patrick Georgi (Code Review)
Philipp Deppenwiese (Code Review)