Attention is currently required from: Lance Zhao, Anil Kumar K, Cliff Huang, Selma Bensaid, Paul Menzel, Thejaswani Putta, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61352 )
Change subject: soc/intel/common/block/pcie/rtd3: Add PM methods to the device.
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/pcie/rtd3/chip.h:
https://review.coreboot.org/c/coreboot/+/61352/comment/c3d80970_ea579787
PS1, Line 53: ext_pm_support
Yup, that will be good.
Then there is still an invalid state; perhaps we can make an enumeration out of the legal combinations?
e.g.
```
enum acpi_pcie_rp_pm_emit {
ACPI_PCIE_RP_EMIT_NORMAL, /* disable_l23=false, ext_pm_support=false */
ACPI_PCIE_RP_EMIT_NONE, /* disable_l23=true, ext_pm_support=false */
ACPI_PCIE_RP_EMIT_EXPORT, /* disable_l23=false, ext_pm_support=true */
};
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61352
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79de76f26c8424b036cb7d2719df68937599ca2f
Gerrit-Change-Number: 61352
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 Jan 2022 21:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Gerrit-MessageType: comment