[S] Change in coreboot[main]: src/device: Add more condition to check valid PCI device id

[Wonkyu Kim (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Pratikkumar V Prajapati, Subrata Banik.

Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84228?usp=email )

Change subject: src/device: Add more condition to check valid PCI device id
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84228/comment/1c32fde5_d2fac621?usp... :
PS2, Line 12: Below are invalid PCI device id cases
            : VID: 0x0 or 0xffff
            : DID: 0x0 or 0xffff
> can you please highlight why some device missed to update VID/DID. […]

Yes, there is issue in valid VID with 0x0 DID in PSS environment. UEFI bootloader ignores the device by checking the case but coreboot did not.

File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/84228/comment/12afeb27_20548601?usp... :
PS2, Line 1225: dummy.vendor = id & 0xffff;
              : 		dummy.device = (id >> 16) & 0xffff;
              : 		if ((dummy.vendor == 0x0000) || (dummy.vendor == 0xffff) ||
              : 			(dummy.device == 0x0000) || (dummy.device == 0xffff)) {
              : 			printk(BIOS_SPEW, "device %s [0x%04x/0x%04x] is not found.\n",
              : 			       dev_path(&dummy), dummy.vendor, dummy.device);
              :
> why don't u make an inline function, as this test is used at multiple places?

Acknowledged