Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/41343 )
Change subject: haswell: Make VGA on FDI work ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/libgfxinit/+/41343/11/common/haswell/hw-gfx-gm... File common/haswell/hw-gfx-gma-pch-lynxpoint.adb:
https://review.coreboot.org/c/libgfxinit/+/41343/11/common/haswell/hw-gfx-gm... PS11, Line 54: subtype Bit_Index is Natural range 0 .. Word32'Size; Word32'Size - 1
https://review.coreboot.org/c/libgfxinit/+/41343/12/common/haswell/hw-gfx-gm... File common/haswell/hw-gfx-gma-power_and_clocks_haswell.adb:
https://review.coreboot.org/c/libgfxinit/+/41343/12/common/haswell/hw-gfx-gm... PS12, Line 283: PCH.Lynxpoint.Disable_Clkout_DP; Disable first?
https://review.coreboot.org/c/libgfxinit/+/41343/12/common/hw-gfx-gma-pch-si... File common/hw-gfx-gma-pch-sideband.adb:
https://review.coreboot.org/c/libgfxinit/+/41343/12/common/hw-gfx-gma-pch-si... PS12, Line 32: 6 Forgot to send a comment earlier: Isn't it 204?