Attention is currently required from: Hung-Te Lin, cong yang, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74341 )
Change subject: soc/mediatek: Add support for regulator VIO18
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Patchset:
PS8:
Could you also submit a patch for MT6366_VRF12 and rebase whole patchset (including CB:74342) ?
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/74341/comment/0fcfb966_9d9e5ed2
PS7, Line 797: voltage_uv
OK,thanks.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c3aa105e648b87fc39f881d762002f67b4422b5
Gerrit-Change-Number: 74341
Gerrit-PatchSet: 8
Gerrit-Owner: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 06:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cong yang
yangcong5@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment