Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
soc/intel/broadwell/pch: Rename USB files
Done to ease diffing against Lynxpoint.
Change-Id: Ib4280b26799eab6d4a2bb41a14a76695caa31e86 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/pch/Makefile.inc R src/soc/intel/broadwell/pch/usb_ehci.c R src/soc/intel/broadwell/pch/usb_xhci.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/47021/1
diff --git a/src/soc/intel/broadwell/pch/Makefile.inc b/src/soc/intel/broadwell/pch/Makefile.inc index 1c19613..1ebe324f 100644 --- a/src/soc/intel/broadwell/pch/Makefile.inc +++ b/src/soc/intel/broadwell/pch/Makefile.inc @@ -32,8 +32,8 @@ bootblock-y += usb_debug.c romstage-y += usb_debug.c ramstage-y += usb_debug.c -ramstage-y += ehci.c -ramstage-y += xhci.c -smm-y += xhci.c +ramstage-y += usb_ehci.c +ramstage-y += usb_xhci.c +smm-y += usb_xhci.c
ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c diff --git a/src/soc/intel/broadwell/pch/ehci.c b/src/soc/intel/broadwell/pch/usb_ehci.c similarity index 100% rename from src/soc/intel/broadwell/pch/ehci.c rename to src/soc/intel/broadwell/pch/usb_ehci.c diff --git a/src/soc/intel/broadwell/pch/xhci.c b/src/soc/intel/broadwell/pch/usb_xhci.c similarity index 100% rename from src/soc/intel/broadwell/pch/xhci.c rename to src/soc/intel/broadwell/pch/usb_xhci.c
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Removed reviewer build bot (Jenkins) with the following votes:
* Verified+1 by build bot (Jenkins) no-reply@coreboot.org
Angel Pons has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Removed reviewer Paul Menzel.
Angel Pons has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Removed reviewer Patrick Rudolph.
Angel Pons has removed Patrick Georgi from this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Removed reviewer Patrick Georgi.
Angel Pons has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Removed reviewer Martin Roth.
Angel Pons has removed Felix Singer from this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Removed reviewer Felix Singer with the following votes:
* Code-Review+2 by Felix Singer felixsinger@posteo.net
Attention is currently required from: Martin Roth, Patrick Rudolph. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47021
to look at the new patch set (#2).
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
soc/intel/broadwell/pch: Rename USB files
Done to ease diffing against Lynxpoint.
Change-Id: Ib4280b26799eab6d4a2bb41a14a76695caa31e86 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/pch/Makefile.inc R src/soc/intel/broadwell/pch/usb_ehci.c R src/soc/intel/broadwell/pch/usb_xhci.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/47021/2
Attention is currently required from: Nico Huber, Martin Roth, Angel Pons, Arthur Heymans, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Patch Set 2: Code-Review+1
Attention is currently required from: Nico Huber, Martin Roth, Angel Pons, Arthur Heymans, Patrick Rudolph. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47021 )
Change subject: soc/intel/broadwell/pch: Rename USB files ......................................................................
soc/intel/broadwell/pch: Rename USB files
Done to ease diffing against Lynxpoint.
Change-Id: Ib4280b26799eab6d4a2bb41a14a76695caa31e86 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47021 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/soc/intel/broadwell/pch/Makefile.inc R src/soc/intel/broadwell/pch/usb_ehci.c R src/soc/intel/broadwell/pch/usb_xhci.c 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Tim Wawrzynczak: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/broadwell/pch/Makefile.inc b/src/soc/intel/broadwell/pch/Makefile.inc index 42d8df1..c4356a9 100644 --- a/src/soc/intel/broadwell/pch/Makefile.inc +++ b/src/soc/intel/broadwell/pch/Makefile.inc @@ -33,8 +33,8 @@ bootblock-y += usb_debug.c romstage-y += usb_debug.c ramstage-y += usb_debug.c -ramstage-y += ehci.c -ramstage-y += xhci.c -smm-y += xhci.c +ramstage-y += usb_ehci.c +ramstage-y += usb_xhci.c +smm-y += usb_xhci.c
ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c diff --git a/src/soc/intel/broadwell/pch/ehci.c b/src/soc/intel/broadwell/pch/usb_ehci.c similarity index 100% rename from src/soc/intel/broadwell/pch/ehci.c rename to src/soc/intel/broadwell/pch/usb_ehci.c diff --git a/src/soc/intel/broadwell/pch/xhci.c b/src/soc/intel/broadwell/pch/usb_xhci.c similarity index 100% rename from src/soc/intel/broadwell/pch/xhci.c rename to src/soc/intel/broadwell/pch/usb_xhci.c
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)