Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 )
Change subject: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35017/16/src/soc/mediatek/mt8183/em...
File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35017/16/src/soc/mediatek/mt8183/em...
PS16, Line 201: pmic_set_vdram1_vol(vdram1);
: pmic_set_vddq_vol(vddq);
If vdram1 and vddq don't need to be changed, should we just set that in mt_set_emi or init_dram, and no need to set again here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e
Gerrit-Change-Number: 35017
Gerrit-PatchSet: 16
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Oct 2019 03:58:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment