Attention is currently required from: Arthur Heymans, Maximilian Brune.
Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83457?usp=email )
Change subject: commonlib/device_tree.c: Add read reg property helper
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/83457/comment/ada15584_ec192436?usp... :
PS3, Line 1013: size_t count = prop->prop.size / (4 * addr_cells + 4 * size_cells);
like this?
Yeah, like this, thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83457?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7846eb8af390d709b0757262025cb819e9988699
Gerrit-Change-Number: 83457
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 24 Jul 2024 19:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org