Attention is currently required from: Krystian Hebel, Michał Żygowski, Paul Menzel.
Sergii Dmytruk has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/84926?usp=email )
Change subject: util/cbmem/cbmem.c: Avoid overflows when parsing TCG TPM logs
......................................................................
Patch Set 3:
(1 comment)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/84926/comment/0dd3af63_76a34834?usp... :
PS3, Line 999: if (current + len >= (uintptr_t)tpm2_log + size) {
`>=` looks weird here and above. Maybe allow this case and add `tpm2_log - current >= sizeof(zero_block) + 4` to the condition of the loop?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84926?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e057db3378b701d046d4e578272b10f294142a7
Gerrit-Change-Number: 84926
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:33:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No