Attention is currently required from: Lean Sheng Tan, Martin L Roth, Matt DeVillier, Sean Rhodes.
Benjamin Doron has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84353?usp=email )
Change subject: payloads/edk2: Fix image alignment
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
A while back, this was broken on, I believe, MinPlatform. From memory, I didn't have the ability to investigate then, I only had in-memory debug logging. While we have different modules, in general, this has the potential to break things because page alignment enables the use of NX. So, has this been tested, and generally, with which features enabled?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84353?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I881bfd1eec55454e444909b845a342a94ba8904b
Gerrit-Change-Number: 84353
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Sat, 14 Sep 2024 15:37:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes