Julius Werner has posted comments on this change. ( https://review.coreboot.org/21598 )
Change subject: util/cbfstool: Add "expand" command to make CBFS span an fmap region ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c@1114 PS1, Line 1114: if (!param.region_name) { nit: Shouldn't this default to COREBOOT like the other commands? (Or, if it does, the error message seems wrong.)
https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c@1300 PS1, Line 1300: "Expand CBFS to span entire region\n"
I considered that, but that quickly devolves in an epic yak shave: We still
Hmm... yeah, okay.