Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30365 )
Change subject: mb/google/hatch: Add HPD GPIO support for displays
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30365/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30365/2/src/mainboard/google/hatch/variants/...
PS2, Line 36: /* USB_C0_DP_HPD */
: PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1),
: /* DDI2_HPD_OPL */
: PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1),
: /* EDP_HPD */
: PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1),
can you please make the comments consistent with above?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30365
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9d52dc0f9916f761c8fdd88c76968aaf663e650
Gerrit-Change-Number: 30365
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 24 Dec 2018 03:53:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment