Attention is currently required from: Andrey Pronin, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58870 )
Change subject: soc/amd/psp_verstage: Init TPM on S0i3 resume
......................................................................
Patch Set 17:
(1 comment)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/58870/comment/a8cbe9ee_c866b832
PS17, Line 403: config PSP_INIT_TPM_ON_S0I3_RESUME
Wondering if it should be done in soc/amd/common/psp_verstage/Kconfig. […]
Probably. Actually, it seems like many of the PSP configs in this file should be in psp_verstage/Kconfig instead of duplicated in cezanne/Kconfig and picasso/Kconfig. Anyone know the reasoning here?
The references in psp_verstage.c are behind CONFIG guards, so this won't break zork as is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58870
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie511928da6a8b4be62621fd2c4c31a8d1e724d48
Gerrit-Change-Number: 58870
Gerrit-PatchSet: 17
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 17 Nov 2021 22:21:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment