Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37870 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37870/3/src/soc/intel/tigerlake/ear... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/37870/3/src/soc/intel/tigerlake/ear... PS3, Line 4: 2019 2020
https://review.coreboot.org/c/coreboot/+/37870/3/src/soc/intel/tigerlake/ear... PS3, Line 25: #define PMC_IPC_USBC_CMD_ID 0xA7 Please align values of these three defines to the same columm as line 29 below
https://review.coreboot.org/c/coreboot/+/37870/3/src/soc/intel/tigerlake/ear... PS3, Line 49: 8 what does 8 represent?
https://review.coreboot.org/c/coreboot/+/37870/3/src/soc/intel/tigerlake/ear... PS3, Line 69: )& nit - space needed between ")" and "&"
https://review.coreboot.org/c/coreboot/+/37870/3/src/soc/intel/tigerlake/ear... PS3, Line 70: )t nit - space needed between ")" and "t"
https://review.coreboot.org/c/coreboot/+/37870/3/src/soc/intel/tigerlake/ear... PS3, Line 75: TODO Remove TODO. If there is still a TODO, please file a bug for it.
https://review.coreboot.org/c/coreboot/+/37870/3/src/soc/intel/tigerlake/ear... PS3, Line 114: , move comma to end of previous line, delete space