Attention is currently required from: Elyes Haouas, Guangjie Song, Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Guangjie Song has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84497?usp=email )
Change subject: soc/mediatek/mt8196: Add mtcmos init support ......................................................................
Patch Set 38:
(8 comments)
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/84497/comment/9926472e_c972a305?usp... : PS36, Line 8: all-y += mtcmos.c
only bootblock needs this driver.
display driver in romstage would call mtcmos_display_power_on() which is implemented in mtcmos
File src/soc/mediatek/mt8196/mtcmos.c:
https://review.coreboot.org/c/coreboot/+/84497/comment/00575bca_2b4da9b5?usp... : PS36, Line 58: MMINFRA0_VOTE
VOTE_BIT
Done
https://review.coreboot.org/c/coreboot/+/84497/comment/29d9127b_b302a2dd?usp... : PS36, Line 120: shift
bit
Done
https://review.coreboot.org/c/coreboot/+/84497/comment/1e6a0db1_484ae6a9?usp... : PS36, Line 238: NULL,
no need.
Done
https://review.coreboot.org/c/coreboot/+/84497/comment/dc7a33af_d19bc326?usp... : PS36, Line 353: || cb == NULL
It is no harm to register a NULL callback.
Done
https://review.coreboot.org/c/coreboot/+/84497/comment/c0475ccc_20804fc4?usp... : PS36, Line 377: 0x%x
%#x
Done
https://review.coreboot.org/c/coreboot/+/84497/comment/399f2d68_626673bb?usp... : PS36, Line 373: : static int mtcmos_wait_for_state(u32 *reg, u32 mask, bool onoff) : { : if (!retry(ACK_DELAY_TIMES, mtcmos_is_setclr_state(reg, mask, onoff), udelay(ACK_DELAY_US))) { : printk(BIOS_ERR, "mtcmos_is_setclr_state(%p, 0x%x, %d) reg_val=0x%x timeout\n", : reg, mask, onoff, read32(reg)); : return -1; : } : : return 0; : }
Done
https://review.coreboot.org/c/coreboot/+/84497/comment/ebacebf6_fd018a04?usp... : PS36, Line 411: ret = mtcmos_bus_prot_ctrl(&bp_table[step_idx], set); : if (ret) { : printk(BIOS_ERR, "mtcmos_bus_prot_ctrl set fail: %d\n", ret); : mtcmos_bus_prot_ctrl(&bp_table[step_idx], !set); : return ret; : }
mtcmos_bus_prot_ctrl always returns zero.
no mtcmos_bus_prot_ctrl would return -1