Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62472 )
Change subject: soc/medaitek/mt8186: set pin drive strength to 8mA for NOR ......................................................................
Patch Set 5:
(3 comments)
File src/soc/mediatek/mt8186/spi.c:
https://review.coreboot.org/c/coreboot/+/62472/comment/aabf084b_e5f758bb PS4, Line 154: /* Set pin drive to GPIO_DRV3 which is defined as 8mA in MT8186 */
The comment is not needed, as the warning log says the same.
Done
https://review.coreboot.org/c/coreboot/+/62472/comment/8c068797_99004a26 PS4, Line 156: printk(BIOS_WARNING, "%s: failed to set pin drive for %d\n",
- … set to 8 mA … […]
it still works for community between SoC to NOR, but the waveform is not correct and there maybe are some impact for this situation.
https://review.coreboot.org/c/coreboot/+/62472/comment/883a6b92_6b6f0826 PS4, Line 160: gpio_get_driving(ptr[i].gpio));
Looks like a debug message?
Done
-
Rex-BC Chen (Code Review)