Attention is currently required from: Saurabh Mishra.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69107 )
Change subject: vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00 ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69107/comment/82a77578_bfc799f8 PS3, Line 7: vc/intel/fsp:Update JSL FSP headers from v2385.04 to v4155.00 Please add a space after the colon.
https://review.coreboot.org/c/coreboot/+/69107/comment/18d2a170_05b9e8ce PS3, Line 10: Previous FSP version was v2385.04 1. Please add a dot/period at the end of sentences. 2. Please add it to the previous line.
https://review.coreboot.org/c/coreboot/+/69107/comment/4efdc602_f12ff28b PS3, Line 11: Include include
https://review.coreboot.org/c/coreboot/+/69107/comment/3a560b6c_982d159f PS3, Line 11: Changes Include: Please add a blank line above.
https://review.coreboot.org/c/coreboot/+/69107/comment/4418a30b_00300863 PS3, Line 12: FspsUpd.h: Change in header offset. : {FspmUpd.h,FspUpd.h}: Copyright year update. : MemInfoHob.h: Add HOB_GUID_TYPE, HOB_GENERIC_HEADER Struct. Plesae format this as a list.
https://review.coreboot.org/c/coreboot/+/69107/comment/e6c1197f_c5aa7b10 PS3, Line 15: Please add a note, why the big version jump 2385 to 4155 only has such a few changes.