build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41816 )
Change subject: soc/amd/picasso: add psp_verstage ......................................................................
Patch Set 9:
(14 comments)
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/fch.c:
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 34: static void iomux_set_bar(void * bar) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 39: static void misc_set_bar(void * bar) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 44: static void gpio_set_bar(void * bar) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 32: svc_debug_print( "Rebooting into recovery\n"); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/svc.h:
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 6: #define SVC_CALL4(SVC_ID, R0, R1, R2, R3, Ret) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 6: #define SVC_CALL4(SVC_ID, R0, R1, R2, R3, Ret) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 19: #define SVC_CALL3(SVC_ID, R0, R1, R2, Ret) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 19: #define SVC_CALL3(SVC_ID, R0, R1, R2, Ret) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 30: #define SVC_CALL2(SVC_ID, R0, R1, Ret) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 30: #define SVC_CALL2(SVC_ID, R0, R1, Ret) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 40: #define SVC_CALL1(SVC_ID, R0, Ret) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 40: #define SVC_CALL1(SVC_ID, R0, Ret) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 49: #define SVC_CALL0(SVC_ID, Ret) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/41816/9/src/soc/amd/picasso/psp_ver... PS9, Line 49: #define SVC_CALL0(SVC_ID, Ret) \ macros should not use a trailing semicolon