Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/25401 )
Change subject: util/intelmetool: Add additional helpful error messages ......................................................................
util/intelmetool: Add additional helpful error messages
Add more verbose error message for common problems on modern operating systems, like Secure Boot and CONFIG_STRICT_DEVMEM.
Change-Id: Ie3361910d48271bcc2cd3b4b74937fbc5df0a176 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/25401 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M util/intelmetool/intelmetool.c M util/intelmetool/rcba.c 2 files changed, 6 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved
diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c index ae36fc5..5981e9d 100644 --- a/util/intelmetool/intelmetool.c +++ b/util/intelmetool/intelmetool.c @@ -491,7 +491,8 @@ #ifndef __DARWIN__ fd_mem = open("/dev/mem", O_RDWR); if (fd_mem < 0) { - perror("Can not open /dev/mem"); + perror("Can not open /dev/mem. Do you have disabled " + "Secure Boot ?"); exit(1); }
diff --git a/util/intelmetool/rcba.c b/util/intelmetool/rcba.c index c138e89..ee43e65 100644 --- a/util/intelmetool/rcba.c +++ b/util/intelmetool/rcba.c @@ -68,7 +68,8 @@
rcba = map_physical((off_t)rcba_phys, size); if (rcba == NULL) { - printf("Could not map RCBA\n"); + printf("Could not map RCBA\n" + "Do you have cmdline argument 'iomem=relaxed' set ?\n"); return 1; } *(uint32_t *)(rcba + addr) = val; @@ -93,7 +94,8 @@
rcba = map_physical((off_t)rcba_phys, size); if (rcba == NULL) { - printf("Could not map RCBA\n"); + printf("Could not map RCBA\n" + "Do you have cmdline argument 'iomem=relaxed' set ?\n"); return 1; }