Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83987?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/common: Print error if GPIO raw_id is not in the range
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/83987/comment/1bc6363c_b3befb44?usp... :
PS3, Line 197: if (!adv_info) {
: printk(BIOS_ERR, "%s: raw_id %u is out of range\n", __func__, gpio.id);
: return -1;
: }
Are you sure we want to return -1 here? The original code seems to suggest that `adv_info` is optional.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83987?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5dffdb9f3e4e7e0d49209e6012893cd246948ee8
Gerrit-Change-Number: 83987
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 22 Aug 2024 03:13:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No