Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29414 )
Change subject: src/soc/intel/braswell: Remove disabled LPE acpi code ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/29414/5/src/soc/intel/braswell/lpe.c File src/soc/intel/braswell/lpe.c:
https://review.coreboot.org/#/c/29414/5/src/soc/intel/braswell/lpe.c@75 PS5, Line 75: file_name, I've never seen this kind of ssdt generation. Why didn't you use the acpigen ? It's common and that way you need to touch only a few files.