Change in coreboot[master]: drivers/usb/acpi: Create function to get PLD information - coreboot-gerrit

12 Jul 2021


      Attention is currently required from: Furquan Shaikh, John Zhao.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56024/comment/114da24f_6c7d22fd 
PS4, Line 129: static struct acpi_pld pld;
...
We can't just remove `static` keyword. […]
Done
We'll pass PLD pointer to function instead keeping context within this function.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf140ce1965dce3a812aa2701ce0e29b34ab3e7
Gerrit-Change-Number: 56024
Gerrit-PatchSet: 8
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Abhijeet Rao abhijeet.rao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: John Zhao john.zhao@intel.com
Gerrit-Comment-Date: Mon, 12 Jul 2021 06:35:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-MessageType: comment