[L] Change in coreboot[main]: drivers/option: Add forms in cbtables - coreboot-gerrit

13 Dec 2024


      Attention is currently required from: Angel Pons, Benjamin Doron, Martin L Roth, Maximilian Brune, Nico Huber, Patrick Rudolph, Sean Rhodes.
Lean Sheng Tan has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email )
Change subject: drivers/option: Add forms in cbtables
......................................................................
Patch Set 22:
(1 comment)
File src/drivers/option/cfr.h:
https://review.coreboot.org/c/coreboot/+/74121/comment/6b7a33aa_2171657a?usp... :
PS22, Line 10: /* Front-end */
...
That front-end should be split to a different header
Which part of this code should be split into another header? Any suggestion on the name? like cdr_frontend.h?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74121?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 22
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Daniel Maslowski info@orangecms.org
Gerrit-CC: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Comment-Date: Fri, 13 Dec 2024 13:55:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com