Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48971 )
Change subject: mb/google/dedede/var/magolor: modify raydium touch screen ......................................................................
mb/google/dedede/var/magolor: modify raydium touch screen
modify raydium touch screen power on timing to meet requirement
BUG=b:174280232 TEST=build firmware and measured the timing
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: I3ecc9d8e21f8c76e9e96cf050dcde83c3c4f4ea7 --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/48971/1
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index d502c91..0a92402 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -202,7 +202,7 @@ register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" register "probed" = "1" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" - register "reset_delay_ms" = "1" + register "reset_delay_ms" = "100" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" register "enable_delay_ms" = "50" register "has_power_resource" = "1"
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48971 )
Change subject: mb/google/dedede/var/magolor: modify raydium touch screen ......................................................................
Patch Set 1: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48971 )
Change subject: mb/google/dedede/var/magolor: modify raydium touch screen ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48971 )
Change subject: mb/google/dedede/var/magolor: modify raydium touch screen ......................................................................
mb/google/dedede/var/magolor: modify raydium touch screen
modify raydium touch screen power on timing to meet requirement
BUG=b:174280232 TEST=build firmware and measured the timing
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: I3ecc9d8e21f8c76e9e96cf050dcde83c3c4f4ea7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48971 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Ren Kuo: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index d502c91..0a92402 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -202,7 +202,7 @@ register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" register "probed" = "1" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" - register "reset_delay_ms" = "1" + register "reset_delay_ms" = "100" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" register "enable_delay_ms" = "50" register "has_power_resource" = "1"
-
Karthik Ramasubramanian (Code Review) -
Patrick Georgi (Code Review)
-
Ren Kuo (Code Review)