Change in coreboot[master]: mb/google/hatch: don't override variant_ramstage_init() in baseboard - coreboot-gerrit

19 Aug 2021


      Attention is currently required from: Jeff Chase, Tim Wawrzynczak, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57037 )
Change subject: mb/google/hatch: don't override variant_ramstage_init() in baseboard
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Instead of adding the same file to all puff variants, why not call `mainboard_puff_ramstage_init()`  […]
This is what I'm thinking of, to be precise: https://paste.flashrom.org/view.php?id=3503
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57037
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e787c3d4c2f2c62a0dc868997b6e4c3da84c43
Gerrit-Change-Number: 57037
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Chase jnchase@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Joe Tessler jrt@google.com
Gerrit-Attention: Jeff Chase jnchase@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Thu, 19 Aug 2021 10:12:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment