the following patch was just integrated into master: commit 032dd14514e72777475c3e39395486627846b7c9 Author: Hung-Te Lin firstname.lastname@example.org Date: Tue Apr 30 15:31:48 2013 +0800
Google/Snow: Remove unnecessary serial console init code.
The "console_init" does initialize UART driver (which will setup peripheral and pinmux) and print starting message. Duplicated initialization can be removed.
Also, console_init (from console.c) is always linked to bootblock (and will do nothing if CONFIG_EARLY_CONSOLE is not defined) so it's safe to remove #ifdef.
Verified by building and booting on Google/Snow, with and without CONFIG_EARLY_CONSOLE.
Change-Id: I0c6b4d4eb1a4e81af0f65bcb032978dfb945c63d Signed-off-by: Hung-Te Lin email@example.com Reviewed-on: http://review.coreboot.org/3150 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel firstname.lastname@example.org Reviewed-by: Ronald G. Minnich email@example.com
Build-Tested: build bot (Jenkins) at Tue Apr 30 11:07:01 2013, giving +1 Reviewed-By: Ronald G. Minnich firstname.lastname@example.org at Tue Apr 30 19:22:05 2013, giving +2 See http://review.coreboot.org/3150 for details.