Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43005 )
Change subject: mb/ocp/deltalake: Send OEM IPMI command for CMOS clear when RTC failure is detected ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG@11 PS6, Line 11: This is to let the payload (LinuxBoot) do some handling.
What kind of handling?
In payload, u-root reads and checks CMOS clear and valid bits via IPMI OEM command, If bits both are set to 1, u-root add a SEL and sends IPMI CMOS clear command to BMC then reboot.
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG@13 PS6, Line 13: Tested on OCP Delta Lake
How is this tested? How do you simulate RTC failure?
Remove RTC battery.
https://review.coreboot.org/c/coreboot/+/43005/6/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/43005/6/src/mainboard/ocp/deltalake... PS6, Line 42: uint8_t boot_dev4;
Regarding boot order, how does the difference between systemboot and UEFI BDS affect it? What is boo […]
It’s an OEM defined IPMI command structure, Byte boot_mode includes CMOS clear and boot flag valid bits, they are OEM defined and are used to detect if CMOS clear request has been set or not, the boot_dev bytes are part of the command structure, they represent boot order from boot_dev0 to boot_dev4, but in this change we do not touch them.