Change in coreboot[master]: soc/intel/{icl,tgl,adl,ehl,jsl}: move UART pad config to boards
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48780 )
Change subject: soc/intel/{icl,tgl,adl,ehl,jsl}: move UART pad config to boards ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
How do you know which boards have multiple UARTs? Removing the common code will make it impossible to use them when changing the UART_FOR_CONSOLE kconfig.
That's not true; the boards just have to configure the pads for all UARTs correctly
https://review.coreboot.org/c/coreboot/+/48780/1/src/mainboard/google/brya/v... File src/mainboard/google/brya/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48780/1/src/mainboard/google/brya/v... PS1, Line 16: PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), : /* C9 : UART0 TX */ : PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), :
PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* UART0 RX */ […]
https://review.coreboot.org/c/coreboot/+/48290/5/src/mainboard/google/brya/v...
-
Michael Niewöhner (Code Review)