Attention is currently required from: Angel Pons, Felix Held, Felix Singer, Martin Roth, Michał Żygowski, Paul Menzel.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83004?usp=email )
Change subject: util/superiotool/fintek: Add f81866 register table
......................................................................
Patch Set 14:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83004/comment/5ffc053a_f548c545?usp... :
PS9, Line 12: 1
Putting URLs in the commit message is discouraged as they frequently become stale as the website cha […]
Done
https://review.coreboot.org/c/coreboot/+/83004/comment/b1adb681_7eca6416?usp... :
PS9, Line 20: LDN 0xfe
`Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Done
File util/superiotool/fintek.c:
https://review.coreboot.org/c/coreboot/+/83004/comment/b47e5967_bc83f55b?usp... :
PS11, Line 521: {0x30,0x60,0x61,0x70,0x71,0x72,0x73,0x7e,0x7f, 0xf0,0xf1,0xf2,0xf3,0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,0xf9, 0xe0,0xe1,0xe2,0xe3,0xe8,0xe9, 0xd0,0xd1,0xd2,0xd3, 0xc0,0xc1,0xc2,0xc3, 0xb0,0xb1,0xb2,0xb3, 0xa0,0xa1,0xa2,0xa3,0xa8,0xa9, 0x90,0x91,0x92,0x93, 0x80,0x81,0x82,0x83, 0x88,0x89,0x8a,0x8b,0x8e,0x8f, 0xef, EOT},
Please wrap these lines, as done in other Super I/Os. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83004?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b
Gerrit-Change-Number: 83004
Gerrit-PatchSet: 14
Gerrit-Owner: Maxim
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 07 Jul 2024 09:21:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com