Attention is currently required from: Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Kapil Porwal, Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Rishika Raj, Shelly Chang, Sowmya Aralguppe, Subrata Banik.
Caveh Jalali has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83735?usp=email )
Change subject: mb/google/brox: Boot to kernel without battery
......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/83735/comment/682c556e_c02782e5?usp... :
PS4, Line 433: google_chromeec_is_battery_present
please split the addition of a new chromeec API into a separate patch.
also, do you really need a new API here?
i would expect that the existing
`google_chromeec_is_battery_present_and_above_critical_threshold`
be a better choice here.
it was introduced in https://review.coreboot.org/c/coreboot/+/78321
to address no-battery booting issues with MTL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83735?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie49ed8f6d8b0fa59ec0e7b06efea9cac4d253957
Gerrit-Change-Number: 83735
Gerrit-PatchSet: 4
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Herrmann
eherrmann@google.com
Gerrit-Reviewer: Forest Mittelberg
bmbm@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Short
keithshort@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Eric Herrmann
eherrmann@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Keith Short
keithshort@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Attention: Forest Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Thu, 01 Aug 2024 19:01:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No