Change in coreboot[master]: soc/qualcomm/common: Make clock_configure() check for exact matches
Attention is currently required from: Shelley Chen, Taniya Das, Paul Menzel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Make clock_configure() check for exact matches ......................................................................
Patch Set 9:
(3 comments)
File src/soc/qualcomm/common/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/3b1a2c12_acb4566a PS8, Line 103: if (hz != clk_cfg[idx].hz)
Done
Please make sure you fix the num_perfs=0 in sc7180 as well.
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/e5fd5331_81561286 PS7, Line 412: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz;
I'm not sure what you're referring to? Can you be more specific?
There are three more tabs in front of this line than there should be (or is there something wrong about how Gerrit displays it?).
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/27f56644_6644125a PS8, Line 418: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz;
Ok, I see. We were still passing in hz to clock_configure(). How about we pass in mdss_clk_cfg. […]
Yes that works too.
-
Julius Werner (Code Review)