HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44100 )
Change subject: src: Remove unused 'include <lib.h>' ......................................................................
src: Remove unused 'include <lib.h>'
Change-Id: Ic09fc4ff4ee5524d89366e28d1d22900dd0c5b4d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/util.c M src/northbridge/intel/ironlake/raminit.c M src/security/intel/txt/ramstage.c M src/soc/intel/common/block/cse/cse_lite.c 4 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/44100/1
diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index cfa83d7..acc3f4b 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -8,7 +8,6 @@ #include <commonlib/fsp.h> #include <console/console.h> #include <fsp/util.h> -#include <lib.h> #include <string.h> #include <types.h>
diff --git a/src/northbridge/intel/ironlake/raminit.c b/src/northbridge/intel/ironlake/raminit.c index f50adb1..17901b0 100644 --- a/src/northbridge/intel/ironlake/raminit.c +++ b/src/northbridge/intel/ironlake/raminit.c @@ -82,8 +82,6 @@ u32 reg_6e8; };
-#include <lib.h> /* Prototypes */ - typedef struct _u128 { u64 lo; u64 hi; diff --git a/src/security/intel/txt/ramstage.c b/src/security/intel/txt/ramstage.c index 8627a2b..145182f 100644 --- a/src/security/intel/txt/ramstage.c +++ b/src/security/intel/txt/ramstage.c @@ -10,7 +10,6 @@ #include <cpu/intel/common/common.h> #include <cpu/x86/msr.h>
-#include <lib.h> #include <device/pci_ops.h>
#include "txt.h" diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index a12f2d0..a2ff4a8 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -7,7 +7,6 @@ #include <commonlib/region.h> #include <fmap.h> #include <intelblocks/cse.h> -#include <lib.h> #include <security/vboot/vboot_common.h> #include <security/vboot/misc.h> #include <vb2_api.h>
Hello build bot (Jenkins), Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44100
to look at the new patch set (#2).
Change subject: src: Remove unused 'include <lib.h>' ......................................................................
src: Remove unused 'include <lib.h>'
Change-Id: Ic09fc4ff4ee5524d89366e28d1d22900dd0c5b4d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/util.c M src/security/intel/txt/ramstage.c M src/soc/intel/common/block/cse/cse_lite.c 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/44100/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44100 )
Change subject: src: Remove unused 'include <lib.h>' ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44100 )
Change subject: src: Remove unused 'include <lib.h>' ......................................................................
src: Remove unused 'include <lib.h>'
Change-Id: Ic09fc4ff4ee5524d89366e28d1d22900dd0c5b4d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44100 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/drivers/intel/fsp2_0/util.c M src/security/intel/txt/ramstage.c M src/soc/intel/common/block/cse/cse_lite.c 3 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index cfa83d7..acc3f4b 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -8,7 +8,6 @@ #include <commonlib/fsp.h> #include <console/console.h> #include <fsp/util.h> -#include <lib.h> #include <string.h> #include <types.h>
diff --git a/src/security/intel/txt/ramstage.c b/src/security/intel/txt/ramstage.c index 8627a2b..145182f 100644 --- a/src/security/intel/txt/ramstage.c +++ b/src/security/intel/txt/ramstage.c @@ -10,7 +10,6 @@ #include <cpu/intel/common/common.h> #include <cpu/x86/msr.h>
-#include <lib.h> #include <device/pci_ops.h>
#include "txt.h" diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index d89044f..c29b56c 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -7,7 +7,6 @@ #include <commonlib/region.h> #include <fmap.h> #include <intelblocks/cse.h> -#include <lib.h> #include <security/vboot/vboot_common.h> #include <security/vboot/misc.h> #include <vb2_api.h>
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)