[M] Change in coreboot[main]: vc/amd/opensil: introduce common mpio/chip.h header file - coreboot-gerrit

8 May 2024


      Attention is currently required from: Martin L Roth, Martin Roth, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82262?usp=email )
Change subject: vc/amd/opensil: introduce common mpio/chip.h header file
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/amd/onyx_poc/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82262/comment/2a8f2e94_7b6fff76 :
PS1, Line 58: vendorcode/amd/opensil/mpio
...
Instead of just dropping it directly into the opensil directory, can we put it in amd/opensil/chips/ […]
the addition chip/ seems a bit redundant to me. maybe "vendorcode/amd/opensil/common/mpio"?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82262?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iead97d1727569ec0d23a2b9c4fd96daff4bebcf6
Gerrit-Change-Number: 82262
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Varshit Pandya pandyavarshit@gmail.com
Gerrit-CC: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Varshit Pandya pandyavarshit@gmail.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 08 May 2024 21:00:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment